Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected], Matrix3.multiplyVector3Array refers to removed function applyToVector3Array XD #11377

Closed
jaygarcia opened this issue May 22, 2017 · 3 comments

Comments

@jaygarcia
Copy link

FYI, installed [email protected].

	Object.assign( Matrix3.prototype, {

		flattenToArrayOffset: function ( array, offset ) {

			console.warn( "THREE.Matrix3: .flattenToArrayOffset() has been deprecated. Use .toArray() instead." );
			return this.toArray( array, offset );

		},
		multiplyVector3: function ( vector ) {

			console.warn( 'THREE.Matrix3: .multiplyVector3() has been removed. Use vector.applyMatrix3( matrix ) instead.' );
			return vector.applyMatrix3( this );

		},
		multiplyVector3Array: function ( a ) {
                       /** SEE below! **/
			console.warn( 'THREE.Matrix3: .multiplyVector3Array() has been renamed. Use matrix.applyToVector3Array( array ) instead.' );
			return this.applyToVector3Array( a );

		},
		applyToBuffer: function( buffer, offset, length ) {

			console.warn( 'THREE.Matrix3: .applyToBuffer() has been removed. Use matrix.applyToBufferAttribute( attribute ) instead.' );
			return this.applyToBufferAttribute( buffer );

		},
		applyToVector3Array: function( array, offset, length ) {
                        /** Orly? **/
			console.error( 'THREE.Matrix3: .applyToVector3Array() has been removed.' );

		}

	} );

These deprecation warnings are great, but when they call a remove method, it feels a bit awkward. Like a dead end.

Was exploring and just found this. =)

@Mugen87
Copy link
Collaborator

Mugen87 commented May 23, 2017

This actually happened here #10367. I think i was not aware that other deprecated methods already referred to .applyToVector3Array().

Maybe we could rewrite methods like . multiplyVector3Array() to:

multiplyVector3Array: function ( a ) {

    console.error( 'THREE.Matrix3: .multiplyVector3Array() has been removed.'  );

},

@mrdoob
Copy link
Owner

mrdoob commented May 23, 2017

Good catch! 😅

@mrdoob
Copy link
Owner

mrdoob commented May 23, 2017

@Mugen87 that sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants