Skip to content

Commit 9c51e5c

Browse files
LikeLakers2mrchantey
authored andcommitted
bevy_gilrs: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] (bevyengine#17245)
# Objective - bevyengine#17111 ## Solution Set the `clippy::allow_attributes` and `clippy::allow_attributes_without_reason` lints to `deny`, and bring `bevy_gilrs` in line with the new restrictions. ## Testing `cargo clippy --tests --package bevy_gilrs` was run, and no errors were encountered.
1 parent b71d3fe commit 9c51e5c

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

crates/bevy_gilrs/src/lib.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
#![cfg_attr(docsrs, feature(doc_auto_cfg))]
22
#![forbid(unsafe_code)]
3+
#![deny(
4+
clippy::allow_attributes,
5+
clippy::allow_attributes_without_reason,
6+
reason = "See #17111; To be removed once all crates are in-line with these attributes"
7+
)]
38
#![doc(
49
html_logo_url = "https://bevyengine.org/assets/icon.png",
510
html_favicon_url = "https://bevyengine.org/assets/icon.png"

crates/bevy_gilrs/src/rumble.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ struct RunningRumble {
2121
/// A ref-counted handle to the specific force-feedback effect
2222
///
2323
/// Dropping it will cause the effect to stop
24-
#[allow(dead_code)]
24+
#[expect(
25+
dead_code,
26+
reason = "We don't need to read this field, as its purpose is to keep the rumble effect going until the field is dropped."
27+
)]
2528
effect: SyncCell<ff::Effect>,
2629
}
2730

0 commit comments

Comments
 (0)