Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code issues #5

Open
leonardltk opened this issue Jun 9, 2019 · 1 comment
Open

code issues #5

leonardltk opened this issue Jun 9, 2019 · 1 comment

Comments

@leonardltk
Copy link

Hi, line 42 of the pySpeechRev.py, the normalisation is wrong. You should abs them before u get the max.

From

# Signal normalization
signal_clean=signal_clean/np.abs(np.max(signal_clean))

to

# Signal normalization
signal_clean=signal_clean/np.max(np.abs(signal_clean))

But actually this might not be the best way to normalise a signal. you should probably calulate the power of the signal and scale them according to the power you desire.

@mravanelli
Copy link
Owner

Fixed, thank you!
Yes, there are different way to provide a smarter normalization but we didn't explored them in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants