Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for devel OpenMP #3

Closed
mratsim opened this issue Oct 25, 2018 · 0 comments · Fixed by #4
Closed

Update for devel OpenMP #3

mratsim opened this issue Oct 25, 2018 · 0 comments · Fixed by #4

Comments

@mratsim
Copy link
Owner

mratsim commented Oct 25, 2018

Following the merging of nim-lang/Nim#9493 the OpenMP annotation string will need to be patched when compiled for 0.19.1/0.20 vs 0.19.

Additionally we can handle both forEach and reduceEach in a unique macro as nb_chunks: var int wouldn't need to be passed anymore.

forEach would only generate #pragma omp for instead of #pragma omp parallel for and rely on a previous #pragma omp parallel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant