Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS and defaults: youtube-dl default format is now bestvideo+bestaudio/best #1867

Closed
yan12125 opened this issue Apr 26, 2015 · 4 comments
Closed

Comments

@yan12125
Copy link
Contributor

References:
[1] #1321
[2] ytdl-org/youtube-dl#5447
[3] ytdl-org/youtube-dl@feccf29

Issue #1321 proposed to use bestvideo+bestaudio as the default format in invoking youtube-dl. Now youtube-dl's default format is bestvideo+bestaudio/best due to the proposal in [2]. As a result, either https://github.com/mpv-player/mpv/blob/master/DOCS/man/options.rst should be updated to conform to the latest changes in youtube-dl, or https://github.com/mpv-player/mpv/blob/master/player/lua/ytdl_hook.lua should enforce best format when passsing arguments.

Note that such changes are not included in the latest stable release 2015.04.17 yet, but it won't be long due to youtube-dl's rapid release schedule.

@ghost ghost closed this as completed in 95a0488 Apr 26, 2015
@ghost
Copy link

ghost commented Apr 26, 2015

OK, the default is now actually "best", instead of letting youtube-dl decide.

@rrooij
Copy link
Contributor

rrooij commented Apr 27, 2015

This breaks:

d453600

It's because the format option takes precedence over the -x option, when downloading a YouTube video.

@jaimeMF
Copy link
Contributor

jaimeMF commented Apr 27, 2015

In that case, you could use -f bestaudio/best instead.

@rrooij
Copy link
Contributor

rrooij commented Apr 27, 2015

@jaimeMF
Thanks for the suggestion.

I think that my commit should be reverted then, since people that don't want to waste bandwidth can use that format option instead of letting mpv pass the -x argument.

ghost pushed a commit that referenced this issue Apr 27, 2015
If the --ytdl-format option is not used, force the "best" format. Do
this because youtube-dl is going to change its default format to one
that will trigger the (partially broken) DASH support in our own code.

Fixes #1867.

(cherry picked from commit 95a0488)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants