Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO before 1.0 release #55

Closed
11 of 12 tasks
mpizenberg opened this issue Feb 4, 2021 · 3 comments
Closed
11 of 12 tasks

TODO before 1.0 release #55

mpizenberg opened this issue Feb 4, 2021 · 3 comments

Comments

@mpizenberg
Copy link
Owner

mpizenberg commented Feb 4, 2021

Here is a list of things that should be nice to fix before a 1.0 release:

@mpizenberg
Copy link
Owner Author

I'll defer the install subcommand and end-to-end tests for the time being.

@mpizenberg
Copy link
Owner Author

mpizenberg commented Feb 9, 2021

Here are some issues discovered by lydell

  • elm-test-rs init overwrote my elm.json with 2 spaces indentation instead of 4 (Elm uses 4). -> look at how to do that with an alternative to serde_json. Fixed in bd47112
  • It also changed the order (of dependencies). Seems to be a mismatch whether - or / is considered to sort first elm/foo vs elm-community/foo -> See if that's a rust/haskell difference in string ordering for BTreeMap or something else. Fixed in Use a struct instead of String for package ids (fix dependencies ordering) #70
  • Another difference compared to node-test-runner: 0 tests (either 0 files, or 0 exposed Test values) is an error in node-test-runner, but not en elm-test-rs. Done in 2c231a0
  • elm-test-rs --root /nope gives no error. -> Rework CLI with clap instead of pico_args
  • elm-test make is missing in elm-test-rs -> will wait after 1.0.0, like install.

@mpizenberg
Copy link
Owner Author

Version 1.0.0 released :) #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant