-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend-explicit tests #108
Comments
@mattsb42-aws This is great work. I have had this in the back of my mind for some time. If it works for you, I could set up a dev branch that we could PR everything into for digestable PRs. Once everything was into the dev bracnh, we could merge that into master. I created a branch https://github.com/mpdavis/python-jose/tree/backend-explicit-tests You can PR individual PRs into that branch. Thanks again. |
Sounds good. #109 created for the initial move. Related to this, I would like to remove the Once that gap is closed, I would like to see what can be done to remove the dependencies for both |
I was looking for that too when implementing different backends. It appears setuptools still can't deal reliably with this according to pypa/setuptools#1139 |
This is resolved with #129 |
The current test framework loads all cryptographic backends and then tests them all in the same pass.
This has a few unintended effects: it makes it impossible to run the tests without all backends present, it masks failures of some tests that will fail when certain backends are not present (because they use the autoloader), and it makes it easier to forget to enable tests for certain backends.
I've been hacking on this and I have the tests reconfigured to enable testing with isolated backends[1], but as noted above the previous approach was masking tests that currently fail when certain backends are not present.
Assuming that this is a change that would be desirable, what would be your preferred way of handling the changes? In the interest of keeping the PRs small and digestible I would rather not lump the test reworking and any fixes together into the same PR, but pushing only the test rework will make the test suite fail.
[1] https://github.com/mattsb42-aws/python-jose/tree/explicit-dependencies
The text was updated successfully, but these errors were encountered: