Skip to content

Conversation

alexs-mparticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • At the time this kit was created, Mixpanel logged Page Views as standard events via their track method. As a workaround, we added a prefix of "Viewed" when sending these events to Mixpanel to allow customers to easily identify events as Page Views.
  • However, this prefix for event names does not allow event names to be properly tracked within the mParticle UI.
  • As a fix, we are only appending the prefix of "Viewed" when sending events to Mixpanel, but retaining the initial event name within mParticle.
  • Note: Mixpanel now supports tracking pageviews. This feature will be implemented in a future revision of this kit.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Using a sample app, log a page view event.
  • The event should appear in Mixpanel with a prefix of "Viewed", and the Event Forwarder Counts should increment.
  • However the event reporting payload should not contain the "Viewed" prefix.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle merged commit f5b4455 into development Dec 4, 2023
github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
## [2.1.2](v2.1.1...v2.1.2) (2023-12-04)

### Bug Fixes

* Prevent event name prefix from being sent to Reporting Service ([#49](#49)) ([f5b4455](f5b4455))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants