You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a follow up to #345 we should fix the sourcemap-based code coverage remapping to make sure it does map correctly with the original source code in src/browser-polyfill.js.
At the moment it isn't the case because the sourcemap is generated by babel when we convert the polyfill script into an umd module, but after the grunt replace plugin has interpolated the content of api-metadata.json into it, which is what prevents the sourcemap-based code coverage to map to the original source code.
As an alternative approach to the grunt replace plugin, we could use a small custom babel plugin to inject the api-metadata.json into the source file, which should allow babel to generate a sourcemap file that maps to the original source instead of the intermediate interpolated file.
The text was updated successfully, but these errors were encountered:
I suggest using a regular build tool that takes care of all of this, sourcemaps would be handled by a single tool. A stable and lightweight solution would be rollup. UMD output is native, the JSON file would be plain import, banners are also supported.
As a follow up to #345 we should fix the sourcemap-based code coverage remapping to make sure it does map correctly with the original source code in src/browser-polyfill.js.
At the moment it isn't the case because the sourcemap is generated by babel when we convert the polyfill script into an umd module, but after the grunt replace plugin has interpolated the content of api-metadata.json into it, which is what prevents the sourcemap-based code coverage to map to the original source code.
As an alternative approach to the grunt replace plugin, we could use a small custom babel plugin to inject the api-metadata.json into the source file, which should allow babel to generate a sourcemap file that maps to the original source instead of the intermediate interpolated file.
The text was updated successfully, but these errors were encountered: