This repository has been archived by the owner on Apr 1, 2019. It is now read-only.
Fix nightly warnings related to lifetimes #17
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following warnings appear:
```
src/command.rs:344:5: 344:56 warning: the trait `core::marker::Sized` is not implemented for the type `Self` [E0277]
src/command.rs:344 fn from_json(body: &Json) -> WebDriverResult<Self>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/command.rs:344:5: 344:56 help: run `rustc --explain E0277` to see a detailed explanation
src/command.rs:344:5: 344:56 note: `Self` does not have a constant size known at compile-time
src/command.rs:344 fn from_json(body: &Json) -> WebDriverResult<Self>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/command.rs:344:5: 344:56 note: this warning results from recent bug fixes and clarifications; it will become a HARD ERROR in the next release. See RFC 1214 for details.
src/command.rs:344 fn from_json(body: &Json) -> WebDriverResult<Self>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/command.rs:344:5: 344:56 note: required by `core::result::Result`
src/command.rs:344 fn from_json(body: &Json) -> WebDriverResult<Self>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
...because of:
rust-lang/rfcs#1214
|
Critic review: https://critic.hoppipolla.co.uk/r/5779 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
jgraham
added a commit
that referenced
this pull request
Sep 2, 2015
Fix nightly warnings related to lifetimes
frewsxcv
added a commit
to frewsxcv/servo
that referenced
this pull request
Sep 2, 2015
In order to pick up these changes: * servo/euclid#101 * netvl/xml-rs#102 * mozilla/webdriver-rust#17
frewsxcv
added a commit
to frewsxcv/servo
that referenced
this pull request
Sep 2, 2015
In order to pick up these changes: * servo/euclid#101 * netvl/xml-rs#102 * mozilla/webdriver-rust#17 * servo/surfman#27
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Sep 2, 2015
Upgrade some dependencies to silence warnings In order to pick up these changes: * servo/euclid#101 * netvl/xml-rs#102 * mozilla/webdriver-rust#17 * servo/surfman#27 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7513) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…rom frewsxcv:bump-no-warnings); r=Ms2ger In order to pick up these changes: * servo/euclid#101 * netvl/xml-rs#102 * mozilla/webdriver-rust#17 * servo/surfman#27 Source-Repo: https://github.com/servo/servo Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following warnings appear:
...because of:
rust-lang/rfcs#1214