-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Snapshot Testing for WASM Inference Tests #946
Comments
My preference from other projects is to use inline snapshots if possible. It makes it easier to review and maintain tests. They are a bit more magical though. |
I would say that inline snapshots via data-driven test assertions is effectively what I've already implemented. Does that mean that you're overall fine with the current format? |
Yeah I'm fine with how things are implemented, but it won't work with the
The benefits of snapshot testing is that the tests can be updated through an automated command as opposed to manually updating the examples yourself. I have found non-inline snapshot hard to use in the past as the expectations are separated from the actual results. |
We now have several test files in inference/wasm/tests/test-cases that compare before-and-after translations.
It would be a good idea to transition these test cases to use vitest's Snapshot capabilities, so that it is easy to change expected assertions when adding new models, or if models change, etc.
The text was updated successfully, but these errors were encountered: