Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim space from age keys #846

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

johanfleury
Copy link
Contributor

@johanfleury johanfleury commented Apr 4, 2021

Fix a bug where settings keys in .sops.yaml using YAML’s multiline strings results in failed to parse input:

$ cat .sops.yaml
creation_rules:
  - path_regex: \.sops\.yaml$
    encrypted_regex: ^(data|stringData)$
    age: >-
      age1XXX,
      age1YYY
$ sops foo.sops.yaml
failed to parse input as Bech32-encoded age public key: malformed recipient " age1YYY": invalid character human-readable part: s[0]=32

@johanfleury johanfleury changed the title Trim space from age keys and PGP fingerprint Trim space from age keys Apr 4, 2021
@johanfleury johanfleury force-pushed the fix/trim-age-keys branch 2 times, most recently from e5fb3c7 to 32b5df5 Compare April 4, 2021 02:58
@johanfleury johanfleury marked this pull request as ready for review April 4, 2021 02:58
@ajvb
Copy link
Contributor

ajvb commented Apr 5, 2021

@johanfleury Thanks for the PR! Can you please change it so it will be merged into develop instead of master.

@johanfleury johanfleury changed the base branch from master to develop April 5, 2021 20:43
@johanfleury
Copy link
Contributor Author

Done :)

@ajvb
Copy link
Contributor

ajvb commented Apr 6, 2021

@johanfleury We just fixed this in #848, but due to making the initial PR against master, tests are not running. Would you mind rebasing against develop or merging mozilla:develop into this branch and pushing up another commit to re-trigger CI?

@johanfleury johanfleury force-pushed the fix/trim-age-keys branch 2 times, most recently from 0cc08da to fdf4517 Compare April 6, 2021 18:22
@johanfleury
Copy link
Contributor Author

Should be good now :)

@ajvb
Copy link
Contributor

ajvb commented Apr 6, 2021

Thank you @johanfleury!

@ajvb ajvb merged commit 1931931 into getsops:develop Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants