Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

The "File size" error message is no longer displayed when uploading a file over 2GB #578

Closed
SoftVision-CosminMuntean opened this issue Sep 27, 2017 · 16 comments
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Firefox 55.0.3 and up

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Steps to reproduce]:

  1. Open the browser and navigate to "send.stage.mozaws.net" page.
  2. Upload a large file over 2GB.
  3. Observe the browser behavior.

[Expected result]:

  • An error message is displayed to warn you that the file size limit is 2GB.

[Actual results]:

  • You are redirected to the "Something went wrong" page.

[Notes]:

  • I recall that there was an error message that was displayed when you tried to upload a large file (over 2GB), but it was probably lost somewhere.
  • Here is a screen recording with the issue:
    over 2b
@johngruen
Copy link
Contributor

Let's add this back in soon.

@johngruen johngruen added this to the Irritable Iguana milestone Sep 27, 2017
@ghost ghost modified the milestones: Irritable Iguana, Stretch Oct 16, 2017
@himanish-star
Copy link
Contributor

@SoftVision-CosminMuntean , @johngruen . I would like to fix this issue

@himanish-star
Copy link
Contributor

@SoftVision-CosminMuntean I face another issue as the page doesn't redirect me and moreover files of size more than 500MB also don't get uploaded in my case

simplescreenrecorder-2017-12-24_11 19 16

@SoftVision-CosminMuntean
Copy link
Author

@himanish-star this is a known issue. Chrome crashes when you try to upload a file larger than 1 GB, see issue #170. But, I suggest you to use Firefox x64 build.

@himanish-star
Copy link
Contributor

Thanks @SoftVision-CosminMuntean , I will do this as soon as possible

@himanish-star
Copy link
Contributor

himanish-star commented Dec 28, 2017

@SoftVision-CosminMuntean , My Firefox version is 57.0.1 (64 bit) , even now the same problem persists and my Firefox browser gets hanged up on uploading and then I got to restart my laptop. Could you try once again and tell me if it works for you

@shikhar-scs
Copy link
Contributor

@himanish-star you still working on this issue ??

@himanish-star
Copy link
Contributor

@shikhar-scs , you can go ahead. My window crashes everytime I upload above 1GB

@SoftVision-CosminMuntean
Copy link
Author

@himanish-star I think you encounter issue #391. If you have a machine that has < 4 GB RAM when you try to upload a large file > 1 GB the website will crash or the system will freeze.

@himanish-star
Copy link
Contributor

himanish-star commented Jan 3, 2018

@SoftVision-CosminMuntean ,yes I do have RAM less than 4GB, and in my case case both the things you mentioned above happen.

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Jan 3, 2018

Thanx @himanish-star for handling me this. I'll work on it and file a PR soon.
@SoftVision-CosminMuntean just wanted to confirm that only a warning is to be displayed or do I also need to cancel the upload for >2GB.

@SoftVision-CosminMuntean
Copy link
Author

After the warning is displayed the upload should be automatically canceled.

@shikhar-scs
Copy link
Contributor

Ok @SoftVision-CosminMuntean I'll keep that in mind

@shikhar-scs
Copy link
Contributor

@SoftVision-CosminMuntean I've filed the PR, keeping all these things in mind. Please review it #695

@SoftVision-CosminMuntean
Copy link
Author

The issue is still reproducible on Send dev and stage servers. If you try to upload a file bigger than 2GB, you are redirected to the "Something went wrong!" page and no error message to warn you that the file size limit is 2GB is displayed.
Tested with latest Nightly 60.0a1 build on Windows 10, 7 x64 and Mac 10.12.

@dannycoates
Copy link
Contributor

DRAG AND DROP!!!!

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

5 participants