-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sccache-dist to use SCCACHE_LOG. #977
Conversation
This fixes mozilla#969 which was overlooked when fixing mozilla#810.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, I remember being affected by this last year. Thanks for the patch 👍
Would you mind updating the docs and tests that are referencing this?
Gentle ping :) |
Sorry, had forgotten about this :) will look at it now. |
This replaces usage of `RUST_LOG` with `SCCACHE_LOG` in the docs and the tests.
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
==========================================
+ Coverage 29.37% 29.38% +0.01%
==========================================
Files 47 47
Lines 16758 16758
Branches 8030 8030
==========================================
+ Hits 4923 4925 +2
Misses 6720 6720
+ Partials 5115 5113 -2
Continue to review full report at Codecov.
|
* Update sccache-dist to use SCCACHE_LOG. This fixes mozilla#969 which was overlooked when fixing mozilla#810. * Update sccache-dist docs and tests. This replaces usage of `RUST_LOG` with `SCCACHE_LOG` in the docs and the tests. * Fix up missed conflict markers...
This fixes #969 which was overlooked when fixing #810.