Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sccache-dist to use SCCACHE_LOG. #977

Merged
merged 4 commits into from
Jun 24, 2022
Merged

Update sccache-dist to use SCCACHE_LOG. #977

merged 4 commits into from
Jun 24, 2022

Conversation

rthomas
Copy link
Contributor

@rthomas rthomas commented Mar 20, 2021

This fixes #969 which was overlooked when fixing #810.

This fixes mozilla#969 which was overlooked when fixing mozilla#810.
Copy link
Contributor

@mitchhentges mitchhentges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I remember being affected by this last year. Thanks for the patch 👍
Would you mind updating the docs and tests that are referencing this?

@drahnr
Copy link
Collaborator

drahnr commented Jun 23, 2022

Gentle ping :)

@rthomas
Copy link
Contributor Author

rthomas commented Jun 24, 2022

Sorry, had forgotten about this :) will look at it now.

rthomas added 2 commits June 25, 2022 05:49
This replaces usage of `RUST_LOG` with `SCCACHE_LOG` in the docs and
the tests.
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #977 (aa698bd) into main (1361839) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
+ Coverage   29.37%   29.38%   +0.01%     
==========================================
  Files          47       47              
  Lines       16758    16758              
  Branches     8030     8030              
==========================================
+ Hits         4923     4925       +2     
  Misses       6720     6720              
+ Partials     5115     5113       -2     
Impacted Files Coverage Δ
src/lib.rs 12.52% <0.00%> (+0.02%) ⬆️
tests/dist.rs 100.00% <ø> (ø)
tests/harness/mod.rs 41.25% <ø> (ø)
tests/oauth.rs 0.64% <0.00%> (ø)
src/jobserver.rs 46.80% <0.00%> (-2.13%) ⬇️
src/azure/blobstore.rs 20.19% <0.00%> (-0.99%) ⬇️
src/compiler/c.rs 37.93% <0.00%> (ø)
src/compiler/rust.rs 33.11% <0.00%> (ø)
src/compiler/gcc.rs 56.87% <0.00%> (+0.23%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1361839...aa698bd. Read the comment docs.

@drahnr drahnr merged commit 02bcd40 into mozilla:main Jun 24, 2022
emabrey pushed a commit to emabrey/sccache that referenced this pull request Aug 10, 2022
* Update sccache-dist to use SCCACHE_LOG.

This fixes mozilla#969 which was overlooked when fixing mozilla#810.

* Update sccache-dist docs and tests.

This replaces usage of `RUST_LOG` with `SCCACHE_LOG` in the docs and
the tests.

* Fix up missed conflict markers...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SCCACHE_LOG in sccache-dist
5 participants