Direct mode doc fixes 3 #2434
Merged
Direct mode doc fixes 3 #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially what it means to hash but not cache a header, which really makes no sense to someone without much knowledge of implementation details. I think it's related to a cache entry being for one source file, but containing several candidate results distinguished by details about the headers they include. AFAIU, there is no reason to care about that as a user because it's always digest of various inputs (cache key) in, result or no result out. I think the new wording catches the gist of it. Reference: if system && config.skip_system_headers in remember_include_file() in c.rs and a bunch of related code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.