-
Notifications
You must be signed in to change notification settings - Fork 611
Fix mtime for reproducable toolchains #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
could you please add a test to make sure we don't regress ? |
4ff5271 to
b9bb613
Compare
|
Yes, of course, I will. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2430 +/- ##
==========================================
+ Coverage 71.50% 71.57% +0.07%
==========================================
Files 65 65
Lines 36302 36365 +63
==========================================
+ Hits 25958 26029 +71
+ Misses 10344 10336 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Added a test, changed the solution to a more correct one during the process |
|
Thanks for the edits. I fixed everything. |
aff8605 to
7d5175f
Compare
7d5175f to
0eb9329
Compare
Hello.
We are running sccache-dist servers in docker and mtime in toolchains is changing, because of this new toolchains appear on the servers.
This request fixes this problem.