Skip to content

Conversation

@nigredon1991
Copy link

Hello.
We are running sccache-dist servers in docker and mtime in toolchains is changing, because of this new toolchains appear on the servers.
This request fixes this problem.

@sylvestre
Copy link
Collaborator

could you please add a test to make sure we don't regress ?

@sylvestre sylvestre force-pushed the fix-mtime-in-toolchains branch from 4ff5271 to b9bb613 Compare August 5, 2025 09:28
@nigredon1991
Copy link
Author

Yes, of course, I will.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.57%. Comparing base (2458b62) to head (0eb9329).

Files with missing lines Patch % Lines
tests/harness/mod.rs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2430      +/-   ##
==========================================
+ Coverage   71.50%   71.57%   +0.07%     
==========================================
  Files          65       65              
  Lines       36302    36365      +63     
==========================================
+ Hits        25958    26029      +71     
+ Misses      10344    10336       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nigredon1991
Copy link
Author

Added a test, changed the solution to a more correct one during the process

@nigredon1991
Copy link
Author

Thanks for the edits. I fixed everything.

@sylvestre sylvestre force-pushed the fix-mtime-in-toolchains branch from aff8605 to 7d5175f Compare September 22, 2025 12:08
@sylvestre sylvestre force-pushed the fix-mtime-in-toolchains branch from 7d5175f to 0eb9329 Compare September 22, 2025 21:24
@sylvestre sylvestre merged commit 75e5e43 into mozilla:main Sep 23, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants