Skip to content

Conversation

@alexcrichton
Copy link
Contributor

Various problems locally meant that I wasn't able to thoroughly test before
pushing up a patch, but now I've fixed those issues and this is tested locally!
Namely:

  • Pass -showIncludes to the preprocessor even if there's no dep file output
    requested.
  • When a dep file is requested and -showIncludes is passed then ship all
    output of dep files to the compiler's stdout.

Various problems locally meant that I wasn't able to thoroughly test before
pushing up a patch, but now I've fixed those issues and this is tested locally!
Namely:

* Pass `-showIncludes` to the preprocessor even if there's no dep file output
  requested.
* When a dep file is requested and `-showIncludes` is passed then ship all
  output of dep files to the compiler's stdout.
@luser luser merged commit f22a7d8 into mozilla:master Apr 11, 2017
@alexcrichton alexcrichton deleted the tmp branch April 11, 2017 19:38
@luser
Copy link
Contributor

luser commented Apr 11, 2017

This does work for me in local testing, it just has one quirk. MSVC outputs the source file name for every compiler invocation, and since we're running the compiler twice we get the source filename output twice:

$ cl -nologo -Fohello.obj -showIncludes -c hello.c -I.
hello.c
Note: including file: .\hello.h
$ /c/build/sccache/target/debug/sccache.exe cl -nologo -Fohello.obj -showIncludes -c hello.c -I.
hello.c
Note: including file: .\hello.h
hello.c

It's not a terribly big deal, just a quirk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants