Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rls and clippy #423

Open
matthiaskrgr opened this issue May 6, 2019 · 6 comments
Open

support rls and clippy #423

matthiaskrgr opened this issue May 6, 2019 · 6 comments

Comments

@matthiaskrgr
Copy link
Contributor

It would be great if sccache supported clippy and rls calls as well.
I tried something like RUSTC_WRAPPER="sccache clippy-driver rustc" but that didn't work out.

@luser
Copy link
Contributor

luser commented May 6, 2019

What would you expect sccache to do in this scenario? AFAIK rls and clippy aren't performing actual compilation so there isn't likely to be any benefit from caching the executions.

@matthiaskrgr
Copy link
Contributor Author

rls calls rustc and dumps its compilation output into target/rls.
clippy-driver also calls rustc, but none of these calls (both clippy and rls) seem to be cached.

I was trying to play around with the code and make it accept "clippy-driver rustc" as a valid "compiler" but to no avail.

@doronbehar
Copy link

I'm not sure about clippy but as for rls, I think it does benefit from having RUSTC_WRAPPER="sccache" set in the environment.

@trinity-1686a
Copy link

As a workaround for clippy, it's possible to run check before as both use the same (rustc managed-)cache. On some project of mine, running clippy directly takes ~4m10s, but running cargo check && cargo clippy takes only ~2m30 by taking advantage of sccache

@luser
Copy link
Contributor

luser commented Aug 30, 2019

It's possible this was fixed by #441

@matthiaskrgr
Copy link
Contributor Author

Similar discussion: #539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants