Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images on medium.com appear twice #599

Open
mikepqr opened this issue Jun 29, 2020 · 3 comments
Open

Images on medium.com appear twice #599

mikepqr opened this issue Jun 29, 2020 · 3 comments

Comments

@mikepqr
Copy link

mikepqr commented Jun 29, 2020

Images in articles on medium.com appear twice in Reader view in Firefox. The first is blurred, the second is not. I don't know if this is the same root cause as #299 (medium.com doing weird stuff with lazy loading), but obviously the symptom is different, so I created a new issue. Please feel free to close as a dupe.

See, e.g. https://medium.com/mozilla-tech/revealing-arch-at-universe-29f4d00c9e58, which looks like this on Firefox 77.0.1 on macOS.

Screen Shot 2020-06-28 at 21 40 48

@msujaws
Copy link

msujaws commented Jul 2, 2020

I'm seeing something slightly different, where the second image doesn't load at all.

The screenshots I'm attaching are the source and the destination, with the destination not having a src attribute on the second image.

Because of minimization there are no useful classNames or other attributes that we can rely on to remove the duplication. I'm not sure how we can fix this, other than trying to find a pattern with the DOM tree nodes.

2020-07-02_1159
2020-07-02_1157

@mikepqr
Copy link
Author

mikepqr commented Jul 19, 2020

This is now happening on the New York Times website too. I think this is new. See e.g. https://www.nytimes.com/2020/07/18/health/coronavirus-anti-vaccine.html. Please let me know if you'd like me to create a separate issue.

@hunterclarke
Copy link

This seems to be resolved in the most recent release (the one that also includes an npm package). https://www.npmjs.com/package/@mozilla/readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants