Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement relaxed, fallback parsing strategy #136

Closed
n1k0 opened this issue Apr 14, 2015 · 2 comments
Closed

Implement relaxed, fallback parsing strategy #136

n1k0 opened this issue Apr 14, 2015 · 2 comments

Comments

@n1k0
Copy link
Contributor

n1k0 commented Apr 14, 2015

As discussed lately, we need to investigate a way to ensure parse() always returns "something". This could be processing page contents a little like how node-unfluff does, as a last-resort fallback strategy.

@n1k0
Copy link
Contributor Author

n1k0 commented Apr 15, 2015

While reading the code flow today, I've noticed that relaxing the number of chars considered not enough for generated page contents to be acceptable[0] helps avoiding having null returned as a result.

[0]

if (this._getInnerText(articleContent, true).length < 500) {

@gijsk
Copy link
Contributor

gijsk commented Mar 15, 2019

#423 eventually ended up implementing this. Took a while, but much better now! \o/

@gijsk gijsk closed this as completed Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants