ExtensionSettings - order of force_installed extensions #705

eMPai-git · 2020-10-26T15:55:32Z

Problem

I had an unexpected behavior with force_installed extensions. It should have installed several extensions but only the first two entries were actually installed. This did work in ESR 68 with the Extensions policy. In ESR 78 with ExtensionSettings the behavior appeared the first time for me.
The policies.json looked like this:

    "ExtensionSettings": {
      "*": {
        "installation_mode": "blocked"
      },
      "jid1-BoFifL9Vbdl2zQ@jetpack": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/decentraleyes/latest.xpi",
        "installation_mode": "force_installed"
      },
      "[email protected]": {
        "install_url": "https://releases.mozilla.org/pub/firefox/releases/78.3.1esr/linux-x86_64/xpi/de.xpi",
        "installation_mode": "force_installed"
      },
      "[email protected]": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi",
        "installation_mode": "force_installed"
      },
      "{33c93ccc-ceed-47d2-9645-805ea58c8a07}": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/first-party-isolation/latest.xpi",
        "installation_mode": "force_installed"
      }
    },

I changed the order and put the languages pack to last place in the list. Now all extensions get installed as expected.

    "ExtensionSettings": {
      "*": {
        "installation_mode": "blocked"
      },
      "jid1-BoFifL9Vbdl2zQ@jetpack": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/decentraleyes/latest.xpi",
        "installation_mode": "force_installed"
      },
      "[email protected]": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi",
        "installation_mode": "force_installed"
      },
      "{33c93ccc-ceed-47d2-9645-805ea58c8a07}": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/first-party-isolation/latest.xpi",
        "installation_mode": "force_installed"
      },
      "[email protected]": {
        "install_url": "https://releases.mozilla.org/pub/firefox/releases/78.3.1esr/linux-x86_64/xpi/de.xpi",
        "installation_mode": "force_installed"
      }
    },

System

Debian 10.6
Firefox 78.3.1 and 78.4.0 (updated during testing, behavior on both versions)

The text was updated successfully, but these errors were encountered:

mkaply · 2020-10-26T16:07:54Z

I'm seeing this error:

https://releases.mozilla.org/pub/firefox/releases/78.3.1esr/linux-x86_64/xpi/de.xpi had unexpected id (got [email protected] expected [email protected])

The ESR doesn't use a different langpack ID, it should be [email protected].

It should have installed the ones after, though. I'll check that.

eMPai-git · 2020-10-26T16:18:06Z

Thank you.

I will change the langpack ID. I cannot remember how I obtained the ID in the first place.

mkaply · 2020-10-26T16:36:22Z

Oddly, I'm seeing all three extensions installed in both cases.

eMPai-git · 2020-10-26T16:45:14Z

Maybe I should do some further testing.

Any hints on how I can help you? The langpack ID error was not shown in about:policies.

mkaply · 2020-10-26T16:47:54Z

Once you fix the ID, do they all install? Can you check the JS Console and see if there are any errors?

eMPai-git · 2020-10-26T17:28:30Z

It does work with the fixed ID.

I'm getting an error OfferToSaveLoginsDefault ignored because OfferToSaveLogins is present.. Probably should have mentioned that in my entry post. I thought this error is unrelated.

mkaply · 2020-10-26T17:52:48Z

That error is definitely unrelated (shouldn't break anything).

If you could try the first one that fails and see if anything comes up on the JS console, that would be great.

eMPai-git · 2020-10-27T11:03:43Z

Ok, here are some new findings:

If I delete the policies.json and look into about:debugging#/runtime/this-firefox I can see that it loads [email protected] by default.

The [email protected] is included in the Debian package firefox-esr-l10n-de.

The force_installed [email protected] seems to not fully load on first start. Some texts of the UI are not translated. A second start fixes that.
The [email protected] seems to be there in this configuration but blocked.

So I changed the ExtensionSettings to allow [email protected]. Everything is fine now besides issue #706

If you could try the first one that fails and see if anything comes up on the JS console, that would be great.

With "JS console" do you mean the Browser console?
If so, there is an error TypeError: addon.sourceURI is null in Policies.jsm:2219:1

mkaply · 2020-10-28T22:12:01Z

So it looks like Debian is improperly renaming the language packs. I just checked our official language packs and they are definitely [email protected]

So if you are installing a language pack from AMO, it should not have the -esr. I have no explanation why using the language pack from AMO isn't working on Debian.

I'm checking into this.

As far as that error goes, that theoretically shouldn't happen, but I'm going to add a check just in case.

mkaply · 2020-10-29T21:24:17Z

So interesting issue. Only debian has the -esr on language packs that come from debian.

So because you're installing language packs from AMO, you should NOT have the -esr on the end. Those are not the IDs when the lang packs come from AMO.

If your URLs were pointing to XPIs on Debian servers, you would use the different ID.

eMPai-git · 2020-10-30T12:29:38Z

So it was a Debian related issue in combination with a wrong langpack ID on my part.

It did some final tests. Here are my conclusions.
Debian 10.6
Installed packages: firefox-esr, firefox-esr-l10n-de

1. Behavior with force_installed langpack and wrong ID

{
  "policies": {
    "ExtensionSettings": {
      "*": {
        "installation_mode": "blocked",
      },
      "[email protected]": {
        "install_url": "https://releases.mozilla.org/pub/firefox/releases/78.4.0esr/linux-x86_64/xpi/de.xpi",
        "installation_mode": "force_installed"
      },
      "[email protected]": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi",
        "installation_mode": "force_installed"
      }
    }
  }
}

[email protected] is the wrong ID for given install_url
[email protected] gets activated
it throws an error TypeError: addon.sourceURI is null in Policies.jsm:2219:1
uBlock Extension (in this example) does not get installed

2. Behavior with force_installed langpack and correct ID

{
  "policies": {
    "ExtensionSettings": {
      "*": {
        "installation_mode": "blocked",
      },
      "[email protected]": {
        "install_url": "https://releases.mozilla.org/pub/firefox/releases/78.4.0esr/linux-x86_64/xpi/de.xpi",
        "installation_mode": "force_installed"
      }
    }
  }
}

[email protected] gets deactivated
[email protected] gets installed and activated

on first start some parts of the UI are not translated

closing and starting Firefox for a second time fixes that

3. Behavior with allowed Debian langpack

{
  "policies": {
    "ExtensionSettings": {
      "*": {
        "installation_mode": "blocked",
      },
      "[email protected]": {
        "installation_mode": "allowed"
      }
    }
  }
}

[email protected] gets activated
everything is fine

4. Behavior with everything blocked

{
  "policies": {
    "ExtensionSettings": {
      "*": {
        "installation_mode": "blocked",
      }
    }
  }
}

[email protected] gets deactivated
no UI translation (as expected)

eMPai-git · 2020-10-30T12:38:31Z

So for me the issue is resolved.
Currently I'm using 3. Behavior with allowed Debian langpack as that did work best with the pre-installed package firefox-esr-l10n-de on my Debian system.
Though I'm wondering why they are renaming the language packs

mkaply · 2020-10-30T15:23:06Z

Though I'm wondering why they are renaming the language packs

It's historical going back to the days of IceWeasel and they don't want to risk moving them back (just talked to the maintainer)

FYI I did put in a bug fix based on the behavior you were seeing (the Js error). Thanks for reporting that.

eMPai-git mentioned this issue Oct 27, 2020

SearchEngines | Remove - Removing all default SearchEngines #706

Open

mkaply closed this as completed Oct 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ExtensionSettings - order of force_installed extensions #705

ExtensionSettings - order of force_installed extensions #705

eMPai-git commented Oct 26, 2020

mkaply commented Oct 26, 2020

eMPai-git commented Oct 26, 2020

mkaply commented Oct 26, 2020

eMPai-git commented Oct 26, 2020 •

edited

Loading

mkaply commented Oct 26, 2020

eMPai-git commented Oct 26, 2020

mkaply commented Oct 26, 2020

eMPai-git commented Oct 27, 2020 •

edited

Loading

mkaply commented Oct 28, 2020

mkaply commented Oct 29, 2020

eMPai-git commented Oct 30, 2020

eMPai-git commented Oct 30, 2020

mkaply commented Oct 30, 2020

ExtensionSettings - order of force_installed extensions #705

ExtensionSettings - order of force_installed extensions #705

Comments

eMPai-git commented Oct 26, 2020

Problem

System

mkaply commented Oct 26, 2020

eMPai-git commented Oct 26, 2020

mkaply commented Oct 26, 2020

eMPai-git commented Oct 26, 2020 • edited Loading

mkaply commented Oct 26, 2020

eMPai-git commented Oct 26, 2020

mkaply commented Oct 26, 2020

eMPai-git commented Oct 27, 2020 • edited Loading

mkaply commented Oct 28, 2020

mkaply commented Oct 29, 2020

eMPai-git commented Oct 30, 2020

1. Behavior with force_installed langpack and wrong ID

2. Behavior with force_installed langpack and correct ID

3. Behavior with allowed Debian langpack

4. Behavior with everything blocked

eMPai-git commented Oct 30, 2020

mkaply commented Oct 30, 2020

eMPai-git commented Oct 26, 2020 •

edited

Loading

eMPai-git commented Oct 27, 2020 •

edited

Loading