Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs aren't being published #1942

Closed
mythmon opened this issue Aug 7, 2019 · 1 comment · Fixed by #2016
Closed

Docs aren't being published #1942

mythmon opened this issue Aug 7, 2019 · 1 comment · Fixed by #2016
Assignees
Labels
documentation P1 - High Priority We're working on this now

Comments

@mythmon
Copy link
Contributor

mythmon commented Aug 7, 2019

In CircleCI our docs-publish job is failing with this error:

$ gh-pages --dotfiles --message "[skip ci] Docs updates" --dist docs/_build/html

The "file" argument must be of type string. Received type undefined
Exited with code 1

Here is an example CI job: https://circleci.com/gh/mozilla/normandy/12787

This job only runs on master, so bors hasn't noticed it. This problem seems to have started recently. I'd guess it is because we don't actually pin a version of the gh-pages tool, and install it via npm install gh-pages@2. We should probably move this to package.json and manage it like all the other Node dependencies.

@shell1 shell1 added this to the Backlog milestone Aug 9, 2019
@shell1 shell1 added documentation P1 - High Priority We're working on this now labels Aug 9, 2019
@glasserc glasserc self-assigned this Oct 8, 2019
@glasserc
Copy link
Contributor

glasserc commented Oct 8, 2019

This build failure seems to have stopped as of gh-pages 2.1.1: https://circleci.com/gh/mozilla/normandy/13389. See tschaub/gh-pages#312. But I still think the idea of explicitly versioning gh-pages is valuable, so I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation P1 - High Priority We're working on this now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants