Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish [email protected] on NPM #393

Closed
madarche opened this issue May 21, 2021 · 16 comments
Closed

Publish [email protected] on NPM #393

madarche opened this issue May 21, 2021 · 16 comments
Assignees

Comments

@madarche
Copy link
Collaborator

Hello @dannycoates. Could you publish [email protected] on NPM please?

Everything is ready on the Git side:

⚠️ The project is now managed through Lerna and thus you will have to do the following to do the publishing:

cd node-convict
npm ci
npx lerna publish from-git

I have explained and justified the project's structure and management in the CONTRIBUTING document.

Please do not hesitate to read, test and ask.

Thanks a lot!

@madarche
Copy link
Collaborator Author

madarche commented Jun 4, 2021

@dannycoates please could you take some time to publish on npm? 🙏

@madarche
Copy link
Collaborator Author

@dannycoates please could you take some time to publish on npm? 🙏 Any problem? Should I ask someone else please?

@ahippler
Copy link
Contributor

@madarche any news?

@madarche
Copy link
Collaborator Author

No news yet, sorry 😢

@madarche
Copy link
Collaborator Author

madarche commented Jul 3, 2021

Hello @pdehaan, we're desperately searching for someone at Mozilla who could publish the new release of convict, and the next ones, to NPM. Could you help us please? 🙏‍‍

@pdehaan
Copy link
Contributor

pdehaan commented Jul 3, 2021

I can reach out on Tuesday. We had a week of PTO last week, and next Monday is a holiday for us in Canada/USA, which means nobody will be checking email/Slack/GitHub.

@madarche
Copy link
Collaborator Author

madarche commented Jul 3, 2021

Thanks a lot @pdehaan!

@ahippler
Copy link
Contributor

ahippler commented Jul 13, 2021

@pdehaan did reach somebody?

@pdehaan
Copy link
Contributor

pdehaan commented Jul 13, 2021

Yeah, sorry. A couple core people were on PTO last week, so I re-pinged the group this morning to try and get this resolved.
I don't have npm permissions for this project, so I can't help much from that end.

@pdehaan
Copy link
Contributor

pdehaan commented Jul 13, 2021

@madarche I heard back that you were added as an npm maintainer (but I don't see you in npm info convict maintainers yet; not sure if that is cached data or if you need to accept some invitation or something).

Hopefully that will unblock you going forward. ❤️

@madarche
Copy link
Collaborator Author

@pdehaan thank you, yes I've been added as an npm maintainer for convict 👍‍‍ 🙇‍‍♂️ ❤️

npm info convict maintainers wasn't showing this before my attempt to publish, but it now shows this after my attempt to publish. So your guess about a cache on this information was right.

So the publishing of [email protected] has been done successfully 😃

… but there's one thing we didn't think about 😟 : convict is now more than one package, and I'm not an npm maintainer for the 2 convict associated packages:

  • convict-format-with-validator
  • convict-format-with-moment

I cannot publish those 😢

@pdehaan could you please help us on this once more?

@pdehaan
Copy link
Contributor

pdehaan commented Jul 18, 2021

Yeah, sorry. I reached out again a few days ago to get permissions for those 2 npm packages. I'll escalate on Monday.

@pdehaan
Copy link
Contributor

pdehaan commented Jul 19, 2021

Yeah, sorry. I reached out again a few days ago to get permissions for those 2 npm packages. I'll escalate on Monday.

@madarche Can you try again?

@madarche
Copy link
Collaborator Author

madarche commented Jul 20, 2021

@pdehaan Yeeees I can publish all the 3 packages now! Many many thanks to you and to all involved! 🙇 🙇 🙇

And thus this ticket is now dealt with and closed!

@pdehaan
Copy link
Contributor

pdehaan commented Jul 20, 2021

All credit goes to the amazing @dannycoates! 👏

@madarche
Copy link
Collaborator Author

Many thanks @dannycoates 🙇‍♂️ 🙇‍♂️ 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants