Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't eat the stack trace when logging errors in the run_tasks helper #73

Open
abpostelnicu opened this issue Oct 11, 2021 · 1 comment
Open

Don't eat the stack trace when logging errors in the run_tasks helper #73

abpostelnicu opened this issue Oct 11, 2021 · 1 comment

Comments

@abpostelnicu
Copy link
Collaborator

Logging should be improved because from time to time we are dealing with issues that lack the necessary logging context in order to be able to fix them.
@marco-c marco-c transferred this issue from mozilla/code-review Oct 11, 2021
@marco-c marco-c changed the title Improve logging for different components across code-review Don't eat the stack trace when logging errors in the run_tasks helper Oct 11, 2021
@marco-c
Copy link
Collaborator

marco-c commented Oct 11, 2021

libmozevent/libmozevent/utils.py

Line 32 in 8acc27a

log.error("Failure while running async tasks", error=str(e))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marco-c @abpostelnicu