Auto-delete queues when the last consumer using them unsubscribes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the harm in overgrowing queues, especially as they get auto deleted by the server after 20k messages ? I don't feel comfortable enabling this in production for code review... |
It has caused tree closures in the past, it causes problems for the publisher.
We haven't even enabled the listening for code review yet, so this can't cause any problem there :P |
|
(let's not merge this yet as we decide in the near future what to do) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
I'm not 100% sure, but I think we should do this.
The disadvantage is that when we e.g. pause code-review or code-coverage the queue will be killed and so we will miss some events;
The big advantage is that we will not cause queues to overgrow (the queues we are using are especially prone to overgrowing, even a few minutes of pause could mean a huge queue).