Skip to content

Commit dd6d4ad

Browse files
mfreed7moz-wptsync-bot
authored andcommitted
Bug 1859941 [wpt PR 42619] - Change expectation for invalid/missing shadowRootMode IDL to null, a=testonly
Automatic update from web-platform-tests Change expectation for invalid/missing shadowRootMode IDL to null Per the spec discussion: whatwg/html#5465 (comment) this changes the expectation for the tests to be: document.createElement("template").shadowRootMode === "" rather than === null. Note that this CL does not change Chromium's behavior, and as such I cannot check if there are other tests that implicitly also do a similar check. More tests might need to change once I (or someone) implements this new behavior in a browser. Bug: 1379513 Change-Id: I0ea1371d612d524fdecc287f3f1790d601c64982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4954120 Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1213658} -- wpt-commits: af6cbc76339f4d2bd67bcee8e1d9b3be879853eb wpt-pr: 42619
1 parent 9194e19 commit dd6d4ad

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: testing/web-platform/tests/shadow-dom/declarative/declarative-shadow-dom-basic.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@
3939
t.setAttribute('shadowrootmode','OpEn');
4040
assert_equals(t.shadowRootMode,'open','Case insensitive');
4141
t.setAttribute('shadowrootmode','INVALID');
42-
assert_equals(t.shadowRootMode,null,'Invalid values map to null');
42+
assert_equals(t.shadowRootMode,'','Invalid values map to empty string');
4343
t.removeAttribute('shadowrootmode');
44-
assert_equals(t.shadowRootMode,null,'No shadowrootmode attribute maps to null');
44+
assert_equals(t.shadowRootMode,'','No shadowrootmode attribute maps to empty string');
4545
}, 'Shadowrootmode reflection');
4646

4747
test(() => {

0 commit comments

Comments
 (0)