From 43ac9a3c2e7a1a3f0ce43cd3da577cce6f06891e Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Fri, 23 Apr 2021 10:17:30 +0000 Subject: [PATCH] Bug 1700509 [wpt PR 28201] - Update offsetParent behavior in shadow trees, a=testonly Automatic update from web-platform-tests Update offsetParent behavior in shadow trees New behavior for offsetParent in shadow trees was discussed in [1] and [2]. This lead to a chromium patch [3] which changed the behavior. After [3] landed, the desired behavior in the discussions in [1] and [2] seemed to have changed. Unfortunately, the author of [3] was no longer working on chromium. This new behavior was then added to the spec and landed in webkit [4] and firefox [5], and a WPT was added for it [6]. This patch implements the new behavior to follow suit with webkit and firefox based on the WPT in [6]. Unfortunately, there are several tests which are either internal to chromium or are only passing in chromium which appear to oppose this new behavior and will have to be updated or removed: - external/wpt/css/css-contain/content-visibility/content-visibility-035.html - external/wpt/css/css-contain/content-visibility/content-visibility-044.html - fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html - shadow-dom/offsetParent.html For shadow-dom/offsetParent.html, I verified that firefox and safari both currently fail the same tests which this patch does. [1] https://github.com/WICG/webcomponents/issues/497 [2] https://github.com/w3c/csswg-drafts/issues/159 [3] https://chromium.googlesource.com/chromium/src/+/18d455ee833f6a30dcbe2755380861eb75cd9f6f [4] https://trac.webkit.org/changeset/239313/webkit [5] https://bugzilla.mozilla.org/show_bug.cgi?id=1514074 [6] https://wpt.fyi/results/shadow-dom/offsetParent-across-shadow-boundaries.html Fixed: 920069 Change-Id: I168edc5ad0e4fcb92d0c4a440623f2424b14a988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2775208 Reviewed-by: Mason Freed Reviewed-by: vmpstr Reviewed-by: Ian Kilpatrick Commit-Queue: Joey Arhar Cr-Commit-Position: refs/heads/master@{#872658} -- wpt-commits: 8d8b8c4e2e42d07398fd5e98b541ee239e1d35a4 wpt-pr: 28201 --- .../css-contain/content-visibility/content-visibility-035.html | 2 ++ .../css-contain/content-visibility/content-visibility-044.html | 2 ++ 2 files changed, 4 insertions(+) diff --git a/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-035.html b/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-035.html index e7f922a0d34bd..bc84c28d4a362 100644 --- a/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-035.html +++ b/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-035.html @@ -7,6 +7,8 @@ + +
diff --git a/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-044.html b/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-044.html index bf4f6168d414e..7378bcd71554a 100644 --- a/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-044.html +++ b/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-044.html @@ -9,6 +9,8 @@ + +