got does not set res.url if gzip encoding response.

[jrgm]

A bunch of tests fail in stage but not latest, and I've reduced it down to this (using [email protected], but happens in [email protected] which we use (I was hoping that a couple of relevant fixes in 6.6.0 might fix this, but no luck)).

// huh.js
var got = require('got')
var url = process.argv[2]
got(url)
  .then((res) => {
    console.log('res.url', res.url, typeof res.url, res.requestUrl)
  })

Output:

$ node huh.js https://accounts.stage.mozaws.net/complete_reset_password
res.url undefined undefined undefined

$ node huh.js https://latest.dev.lcip.org/complete_reset_password
res.url https://latest.dev.lcip.org/complete_reset_password string https://latest.dev.lcip.org/complete_reset_password

[jrgm]

The problem is got handling gzip. The stage server will reply with Content-Encoding: gzip if Accept-Encoding: gzip, while latest will not.

Accept-Encoding: gzip, deflate is set by default by got, if Accept-Encoding is not set.

This version works:

var got = require('got')
var url = process.argv[2]
var requestOptions = {
  headers: {
    'accept-encoding': 'identity'
  }
}
got(url, requestOptions)
  .then((res) => {
    console.log('res.url', res.url, typeof res.url, res.requestUrl)
  })

Output:

$ node huh.js https://latest.dev.lcip.org/complete_reset_password
res.url https://latest.dev.lcip.org/complete_reset_password string https://latest.dev.lcip.org/complete_reset_password

$ node huh.js https://accounts.stage.mozaws.net/complete_reset_password
res.url https://accounts.stage.mozaws.net/complete_reset_password string https://accounts.stage.mozaws.net/complete_reset_password

[jrgm]

Filed reduced testcase using http://google.com: sindresorhus/got#240

[vladikoff]

👍