Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove py dependency? #14851

Open
2 of 3 tasks
janbrasna opened this issue Jul 18, 2024 · 1 comment · May be fixed by #14867
Open
2 of 3 tasks

Remove py dependency? #14851

janbrasna opened this issue Jul 18, 2024 · 1 comment · May be fixed by #14867

Comments

@janbrasna
Copy link
Contributor

janbrasna commented Jul 18, 2024

Description

There's still py==1.11.0 required in dev.in, which is in maintenance mode (=basically conserved in its historic state only). Not being actively updated for years, and with vulnerability being reported even for the latest version, every package tries to get rid of it or just vendor the usable parts instead of all the old legacy… (The CVE is somewhat unfortunate nonetheless, as it only applies to decades-old code for handling SVN repos:/…)

Note

The og py.test entrypoints of pytest do not depend on this in any way.

Is it really being used anywhere?
(Or am I overlooking something too obvious?)

Screenshot 2024-07-21 at 19 03 47


Success Criteria

  • Audit the use of py package
  • Remove if not needed anymore
  • Ensure docs and test runners use pytest not py.test
@janbrasna
Copy link
Contributor Author

janbrasna commented Jul 22, 2024

FYI py is not needed for py.test (cli) to work, it has been independent on it completely for years (several major versions):

But good point @stevejalim to also update the entrypoints. They are nonetheless independent on the requirement removal.


What turned out as a blocker however, is pytest's removal of py in 7.2.0 and vendoring just the useful bits left its plugins without explicit py dependency but still relying on e.g. py.xml broken from that point on, so only those still maintained and updating/replacing their dependencies will continue working with newer releases (or will need a py version explicitly required and pinned like here now, until updated). But that upgrade is currently blocked: #14013 (also see #14316 for more issues, we kinda need both pytest-selenium 4.0.2+ and pytest 8+ so I'll have to try to make a minimal-repro case to test the combination of versions & geckodriver +possible snap/flat env issues, and try finding a version combination that still works for Firefox). Truth is replacing Selenium with Playwright might happen faster than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant