Skip to content

Commit 434bb4a

Browse files
committed
Remove Pocket mode functional tests
1 parent 84357af commit 434bb4a

File tree

11 files changed

+4
-225
lines changed

11 files changed

+4
-225
lines changed

bin/integration_tests/functional_tests.sh

-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ docker run \
6161
-e "PLATFORM=${PLATFORM:-}" \
6262
-e "MARK_EXPRESSION=${MARK_EXPRESSION:-}" \
6363
-e "BASE_URL=${BASE_URL:-}" \
64-
-e "BASE_POCKET_URL=${BASE_POCKET_URL:-}" \
6564
-e "PYTEST_PROCESSES=${PYTEST_PROCESSES:=4}" \
6665
-e "BOUNCER_URL=${BOUNCER_URL:=https://download.mozilla.org/}" \
6766
-e "SCREEN_WIDTH=1600" \

docs/testing.rst

+4-18
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ to pull in external data such as event/blog feeds etc. These are required for
304304
some of the tests to pass.
305305

306306
To run the full Selenium integration test suite against your local bedrock
307-
instance in Mozorg mode:
307+
instance:
308308

309309
.. code-block:: bash
310310
@@ -314,25 +314,11 @@ This will run all test suites found in the ``tests/functional`` directory and
314314
assumes you have bedrock running at ``localhost`` on port ``8000``. Results will
315315
be reported in ``tests/functional/results.html``.
316316

317-
To run the full Selenium test suite against your local bedrock instance in
318-
Pocket mode, things are slightly different, because of the way things are set
319-
up in order to allow CI to test both Mozorg Mode and Pocket Mode at the same
320-
time. You need to define a temporary environment variable (needed by the
321-
`pocket_base_url` fixture) and scope pytest to only run Pocket tests:
322-
323-
.. code-block:: bash
324-
325-
$ BASE_POCKET_URL=http://localhost:8000 pytest -m pocket_mode --driver Firefox --html tests/functional/results.html tests/functional/
326-
327-
This will run all test suites found in the ``tests/functional`` directory that have
328-
the pytest "`mark`" of `pocket_mode` and assumes you have bedrock running *in Pocket mode* at
329-
``localhost`` on port ``8000``. Results will be reported in ``tests/functional/results.html``.
330-
331317
.. Note::
332318

333-
If you omit the ``--base-url`` command line option in Mozorg mode (ie, not
334-
in Pocket mode) then a local instance of bedrock will be started, however
335-
the tests are not currently able to run against bedrock in this way.
319+
If you omit the ``--base-url`` command line option then a local instance
320+
of bedrock will be started, however the tests are not currently able to
321+
run against bedrock in this way.
336322

337323
By default, tests will run one at a time. This is the safest way to ensure
338324
predictable results, due to

setup.cfg

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ markers =
1616
skip_if_internet_explorer
1717
skip_if_not_firefox
1818
smoke
19-
pocket_mode
2019

2120

2221
[tool:paul-mclendahand]

tests/conftest.py

-10
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,7 @@
44

55
import pytest
66

7-
from bedrock.base.config_manager import config
8-
97

108
@pytest.fixture(scope="session")
119
def base_url(base_url, request):
1210
return base_url or request.getfixturevalue("live_server").url
13-
14-
15-
@pytest.fixture(scope="session")
16-
def pocket_base_url(request):
17-
base_url = config("BASE_POCKET_URL", parser=str, default="")
18-
if not base_url:
19-
pytest.skip("No BASE_POCKET_URL detected in env vars")
20-
return base_url

tests/functional/pocket/__init__.py

-3
This file was deleted.

tests/functional/pocket/test_navigation.py

-44
This file was deleted.

tests/functional/pocket/test_navigation_platform.py

-15
This file was deleted.

tests/pages/pocket/__init__.py

-3
This file was deleted.

tests/pages/pocket/about.py

-9
This file was deleted.

tests/pages/pocket/add.py

-9
This file was deleted.

tests/pages/pocket/base.py

-112
This file was deleted.

0 commit comments

Comments
 (0)