Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcribe.py functionality and docs #2566

Closed
JRMeyer opened this issue Dec 3, 2019 · 5 comments · Fixed by #2879
Closed

transcribe.py functionality and docs #2566

JRMeyer opened this issue Dec 3, 2019 · 5 comments · Fixed by #2879

Comments

@JRMeyer
Copy link
Contributor

JRMeyer commented Dec 3, 2019

transcribe.py has odd directory-scanning behavior which isn't documented

If you point --src to a directory, you get the error:

E Path in --src not existing

Looking at the code logic, the script expects a JSON file with a .catalog file extension. This is (1) not documented, and (2) not a really useful logic. It would be much better to point the script to a dir, and scan for audio, and then decode.

would you welcome a PR for this?

@JRMeyer
Copy link
Contributor Author

JRMeyer commented Dec 3, 2019

I made a PR addressing this: #2567

@rhamnett
Copy link
Contributor

rhamnett commented Apr 6, 2020

This can be closed, works well. Thanks

@lissyx lissyx linked a pull request Apr 6, 2020 that will close this issue
@lissyx lissyx closed this as completed Apr 6, 2020
@lissyx lissyx assigned JRMeyer and unassigned tilmankamp Apr 6, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

2 similar comments
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants