Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Autocomplete incorrectly fills urls that contain a port number. #3983

Closed
Mossop opened this issue Jul 10, 2019 · 2 comments
Closed

[Bug] Autocomplete incorrectly fills urls that contain a port number. #3983

Mossop opened this issue Jul 10, 2019 · 2 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search

Comments

@Mossop
Copy link

Mossop commented Jul 10, 2019

Steps to reproduce

  1. Have a url in your history that contains a port number (e.g. localhost:3012).
  2. Start typing the url into the address bar (e.g. loc)
  3. See what autofills

Expected behavior

localhost:3012

Actual behavior

localhost/:3012

Device information

  • Android device: Moto G7
  • Fenix version: 1.0.0 #11721515

┆Issue is synchronized with this Jira Task

@Mossop Mossop added the 🐞 bug Crashes, Something isn't working, .. label Jul 10, 2019
@mcarare
Copy link
Contributor

mcarare commented Jul 12, 2019

@grigoryk I've investigated this, it has to do with matchSegment function in DomainMatcher from android components. Before I make a PR for changing the placement of '/' , I wanted to ask if the desired functionality should also offer suggestions for url containing paths (localhost:8080/manager/html)

@sv-ohorvath
Copy link
Contributor

Verified on Nightly 190806 the "/" is in the right place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search
Projects
None yet
Development

No branches or pull requests

4 participants