Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Grid View] Grid View tabs width changes when synced tabs tray is enabled #15799

Closed
heiwiper opened this issue Oct 9, 2020 · 4 comments
Closed

[Grid View] Grid View tabs width changes when synced tabs tray is enabled #15799

heiwiper opened this issue Oct 9, 2020 · 4 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:SyncTabs Sync tabs Feature:Tabs

Comments

@heiwiper
Copy link

heiwiper commented Oct 9, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

1- Enable tabs Grid View
2- Enable Synced tabs in the tab tray
4- Open few tabs
5- Click on the tab trays button
6- Click and hold on a tab
7- Click the cross button to cancel selecting tabs

Expected behavior

  • Tabs don't change dimensioni

Actual behavior

  • Tabs width changes to fit tabs tray width

Device information

  • Android device: Yes version 10 Custom ROM
  • Fenix version: Nightly 201008 17:08 (Build #2015768523)

┆Issue is synchronized with this Jira Task
@heiwiper heiwiper added the 🐞 bug Crashes, Something isn't working, .. label Oct 9, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 9, 2020
@karan-kamat
Copy link

Can confirm
Also seems to break the synced tabs part for me
The first device name seems to be misplaced

nightly-grid-break

@gabrielluong gabrielluong added Feature:Tabs Skittle and removed needs:triage Issue needs triage labels Oct 9, 2020
@gabrielluong
Copy link
Member

Thank you for finding the issue!

@gabrielluong gabrielluong changed the title [Bug] Grid View tabs width changes when synced tabs tray is enabled [Grid View] Grid View tabs width changes when synced tabs tray is enabled Oct 9, 2020
@eliserichards eliserichards self-assigned this Oct 14, 2020
@eliserichards
Copy link
Contributor

Figma mocks: https://www.figma.com/file/luMaQYjwiMtQM5xQ30P9yP/Tabs?node-id=0%3A1

@eliserichards
Copy link
Contributor

eliserichards commented Oct 15, 2020 •
edited
Loading

This is no longer relevant since the synced tabs UI refactor will move this out of this area of the tabs tray #14117

@eliserichards eliserichards removed their assignment Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. Feature:SyncTabs Sync tabs Feature:Tabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gabrielluong @heiwiper @eliserichards @karan-kamat