Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Swipe to delete on tab with thumbnail makes it show up for a brief second #7282

Closed
jonalmeida opened this issue Jun 5, 2020 · 2 comments
Closed

Swipe to delete on tab with thumbnail makes it show up for a brief second #7282

jonalmeida opened this issue Jun 5, 2020 · 2 comments
Labels
🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs <thumbnails> Components: browser-thumbnails

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Jun 5, 2020 •
edited by data-sync-user
Loading

Steps to Reproduce

  1. Load a tab open; ensure there is a thumbnail.
  2. Swipe to delete the tab.

Expected

  • The tab should animate out.

Actual

  • The tab animates out, then shows up again before going away.

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added 🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs <thumbnails> Components: browser-thumbnails labels Jun 5, 2020
@jonalmeida
Copy link
Contributor Author

I think we can check if this is fixed when we ensure the tabs are not updating too often from changes in the browser state.

cc: @gabrielluong

@liuche liuche mentioned this issue Jun 8, 2020
Closed
@jonalmeida jonalmeida mentioned this issue Jun 9, 2020
Closed
@jonalmeida
Copy link
Contributor Author

jonalmeida commented Jun 16, 2020 •
edited
Loading

This should be fixed now with #7313.

@jonalmeida jonalmeida mentioned this issue Jun 23, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs <thumbnails> Components: browser-thumbnails
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonalmeida