Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Remove hack for Microphone, because is not behaving in the same way as other permissions #2668

Closed
Amejia481 opened this issue Apr 7, 2019 · 1 comment
Labels
🐞 bug Something isn't working needs:gv To implement/fix this we need a new API in GeckoView <sitepermissions> Component: feature-sitepermissions
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Apr 7, 2019

Before we show a prompt for a site permission, we get a request from PermissionDelegate.onAndroidPermissionsRequest to request all the Android permissions needed and if all are granted, we get a call on PermissionDelegate.onMediaPermissionRequest or PermissionDelegate.onContentPermissionRequest to show the prompt. If the Android permissions are deny we don't get any call to neither of the functions above. But for the microphone permission we are getting a call to this function after the android permissions was denied, causing a bad user experience.

To prevent this behavior we added a check for this. The idea is to remove it after the API is fix.

More details
https://bugzilla.mozilla.org/show_bug.cgi?id=1542627

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 added <sitepermissions> Component: feature-sitepermissions 🐞 bug Something isn't working needs:gv To implement/fix this we need a new API in GeckoView labels Apr 7, 2019
@Amejia481
Copy link
Contributor Author

Closed in favor of #6299

@pocmo pocmo added this to the 37.0.0 🌱 milestone Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working needs:gv To implement/fix this we need a new API in GeckoView <sitepermissions> Component: feature-sitepermissions
Projects
None yet
Development

No branches or pull requests

2 participants