Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POMDP - Add information about which memory nodes of external FSC was used in cut-offs #688

Open
TheGreatfpmK opened this issue Mar 11, 2025 · 0 comments
Assignees

Comments

@TheGreatfpmK
Copy link
Contributor

This is a small feature request aimed probably at @AlexBork.

Currently, the BeliefExplorationPomdpModelChecker returns the computed result as BeliefExplorationPomdpModelChecker::Result struct which contains DTMC with states/choices labelled so that the strategy can be constructed from it. The problem is that if an external FSC was provided to the BeliefMdpExplorer it will only report that external FSC was used in a cut-off via the label "finite_mem" however no information about which memory node of the FSC was used is provided. This information is crucial to construct the strategy into an FSC, which would be great for the SAYNT algorithm (the current output is a bit of mess with many different objects).

I did some digging and it seems that at the level of belief exploration, this information is stored in the belief MDP https://github.com/moves-rwth/storm/blob/master/src/storm-pomdp/modelchecker/BeliefExplorationPomdpModelChecker.cpp#L1255 in the form of "mem_node_X" label where X is the index of the used memory node, however when the DTMC for the result is created this information is dropped (here https://github.com/moves-rwth/storm/blob/master/src/storm-pomdp/modelchecker/BeliefExplorationPomdpModelChecker.cpp#L652 and here https://github.com/moves-rwth/storm/blob/master/src/storm-pomdp/modelchecker/BeliefExplorationPomdpModelChecker.cpp#L541) and is just replaced with the "finite_mem" label. Maybe we can just add this information to the end of the "finite_mem" label?

@AlexBork AlexBork self-assigned this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants