Inline a copy of _PyUnicode_Copy
#62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silences compiler errors in Python 3.13
movermeyer
force-pushed
the
movermeyer/inline__PyUnicode_Copy
branch
from
279ed23 to
fb85e47
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Silences compiler errors in Python 3.13. Fixes #61.
python/cpython#106382 moved the
_PyUnicodeAPI functions elsewhere.What approach did you choose and why?
Instead of backporting the current Python 3.13 datetimemodule.c code, I simply inlined the
_PyUnicode_Copymethod. Much easier.I also changed the example
pip installcommand in the README to include the; python_version < '3.11'version specifier, to hopefully encourage correct usage.What should reviewers focus on?
🤷
The impact of these changes
Silences compiler errors in Python 3.13.
While no one should bother using
backports.datetime_fromisoformatwith Python 3.13, people still do (presumably since they don't know to use; python_version < '3.11'in their dependencies).Testing
Build once again work in Python 3.13: