Implement proxied connections #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature is implemented as follows: - when creating a host, there is a possiblity to add a "hop" - hops are referend them with the name of the host in sshportal - the hop ID is then saved in the DB in the hosts table - when connecting to a host, sshportal will recurse through all the possible hops of a host (allowing chained proxies)
- allow changing the hop set for this host - allow removing hops altogether
|
Tested, and approved :) That's super nice and works quite good with fantastic performances (considering alternatives with interactive jump hosts) Thanks a lot! Do you feel the motivation to add some documentation on the README? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows admins to define a "hop" when creating a server (typically needed when a machine is inside a walled network, with only one entrypoint).
The feature is implemented as follows:
Special notes for your reviewer:
I don’t know if this feature is wanted, but we found it quite useful. I couldn't find a contributing guide, but I'm of course open to any code change that may be needed to properly integrate this code in the project.