Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fetch repository if it not already exist in db #530

Merged

Conversation

MikaelVallenet
Copy link
Collaborator

@MikaelVallenet MikaelVallenet commented Jul 22, 2022

Resolve #529

The problem is explain in #529, so i decided to add the feature:
Fetch the repository if it doesn't exist in the database, this way the request is only made if the repository doesn't exist.

I tried to use DepViz to get a graph of the Gno repository

Before the implementation :

before

After the implemantation :

after

Now we can use DepViz on all repositories without launching manually with the CLI the fetch of each repository

┆Issue is synchronized with this Trello card

@MikaelVallenet MikaelVallenet requested a review from moul as a code owner July 22, 2022 16:30
@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 22, 2022
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 22, 2022
Copy link
Owner

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 23, 2022
@moul moul mentioned this pull request Jul 23, 2022
@moul-bot moul-bot force-pushed the 529-add-fetch-repository-on-generate branch from 6f8b7fd to 5dd807b Compare July 23, 2022 21:47
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ✅ Approved Pull Request has been approved and can be merged labels Jul 23, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #530 (612404b) into master (3d336c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   27.95%   27.95%           
=======================================
  Files           6        6           
  Lines         440      440           
=======================================
  Hits          123      123           
  Misses        315      315           
  Partials        2        2           
Flag Coverage Δ
unittests 27.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@MikaelVallenet MikaelVallenet requested a review from moul July 26, 2022 07:16
@moul moul merged commit 3d8c21d into moul:master Aug 4, 2022
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🎉 This PR is included in version 3.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the fetch of a repository in case it is not in the db
2 participants