From b8de45bd29cec9c8dfd12b0a375c465cc696da2b Mon Sep 17 00:00:00 2001
From: Manfred Touron <m@42.am>
Date: Thu, 27 Dec 2018 15:39:20 +0100
Subject: [PATCH] build: add a lint step in CI

---
 .circleci/config.yml         |  5 ++++-
 .golangci.yml                | 34 ++++++++++++++++++++++++++++++++++
 Makefile                     |  4 ++++
 pkg/airtabledb/airtabledb.go |  2 +-
 pkg/issues/doc.go            |  1 +
 5 files changed, 44 insertions(+), 2 deletions(-)
 create mode 100644 .golangci.yml
 create mode 100644 pkg/issues/doc.go

diff --git a/.circleci/config.yml b/.circleci/config.yml
index fa64c202..6d627145 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -9,4 +9,7 @@ jobs:
     steps:
       - checkout
       - run: go get -v -t -d ./...
-      - run: go test -v ./...
+      - run: make install
+      - run: make test
+      - run: curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s v1.12.2
+      - run: make lint
diff --git a/.golangci.yml b/.golangci.yml
new file mode 100644
index 00000000..cf01fa4c
--- /dev/null
+++ b/.golangci.yml
@@ -0,0 +1,34 @@
+run:
+  deadline: 1m
+  tests: false
+  #skip-files:
+  #  - ".*\\.gen\\.go"
+
+linters-settings:
+  golint:
+    min-confidence: 0
+  maligned:
+    suggest-new: true
+  goconst:
+    min-len: 5
+    min-occurrences: 4
+  misspell:
+    locale: US
+
+linters:
+  disable-all: true
+  enable:
+    - goconst
+    - misspell
+    - deadcode
+    - misspell
+    - structcheck
+    - errcheck
+    - unused
+    - varcheck
+    - staticcheck
+    - unconvert
+    - gofmt
+    - goimports
+    - golint
+    - ineffassign
diff --git a/Makefile b/Makefile
index af5ec4fc..ad96022f 100644
--- a/Makefile
+++ b/Makefile
@@ -6,6 +6,10 @@ install:
 test:
 	go test -v ./...
 
+.PHONY: lint
+lint:
+	golangci-lint run --verbose ./...
+
 .PHONY: update_examples
 update_examples:
 	for dir in $(sort $(dir $(wildcard examples/*/*))); do (cd $$dir && make); done
diff --git a/pkg/airtabledb/airtabledb.go b/pkg/airtabledb/airtabledb.go
index 015d8ad0..b9f2b8c7 100644
--- a/pkg/airtabledb/airtabledb.go
+++ b/pkg/airtabledb/airtabledb.go
@@ -1,4 +1,4 @@
-package airtabledb
+package airtabledb // import "moul.io/depviz/pkg/airtabledb"
 
 import (
 	"encoding/json"
diff --git a/pkg/issues/doc.go b/pkg/issues/doc.go
new file mode 100644
index 00000000..f36abd95
--- /dev/null
+++ b/pkg/issues/doc.go
@@ -0,0 +1 @@
+package issues // import "moul.io/depviz/pkg/issues"