Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed in 1.9.17] Taskbar context menu titles are broken on Windows 11 Dev 26120.1252 #495

Closed
CatPieLeaf opened this issue Jul 25, 2024 · 14 comments

Comments

@CatPieLeaf
Copy link

CatPieLeaf commented Jul 25, 2024

Fixed in Canary version 1.9.17.

Update your Nilesoft shell to get this fixed.

image

Some text is missing on nilesoft shell taskbar context menu in Windows 11 24H2 Insider (Dev channel) 26120.1252

Updated temporary workaround:

Thanks to RubicBG

(change your taskbar.nss to this)

menu(type="taskbar" vis=key.shift() or key.lbutton() pos=0 title=app.name image=\uE249)
{
	item(title="config" image=\uE10A cmd='"@app.cfg"')
	item(title="manager" image=\uE0F3 admin cmd='"@app.exe"')
	item(title="directory" image=\uE0E8 cmd='"@app.dir"')
	item(title="version\t"[email protected] vis=label col=1)
	item(title="docs" image=\uE1C4 cmd='https://nilesoft.org/docs')
	item(title="donate" image=\uE1A7 cmd='https://nilesoft.org/donate')
}
menu(where=@(this.count == 0) type='taskbar' image=icon.settings expanded=true)
{
	menu(title="Apps" image=\uE254)
	{
		item(title='Paint' image=\uE116 cmd='mspaint')
		item(title='Edge' image cmd='@sys.prog32\Microsoft\Edge\Application\msedge.exe')
		item(title='Calculator' image=\ue1e7 cmd='calc.exe')
		item(title=str.res('regedit.exe,-16') image cmd='regedit.exe')
	}
	menu(title='Windows' image=\uE1FB)
	{
		item(title='Cascade' cmd=command.cascade_windows)
		item(title=str.res('C:\Windows\explorer.exe', -538) cmd=command.Show_windows_stacked)
		item(title=str.res('C:\Windows\explorer.exe', -536) cmd=command.Show_windows_side_by_side)
		sep
		item(title=str.res('C:\Windows\explorer.exe', -537) cmd=command.minimize_all_windows)
		item(title='Restore all windows' cmd=command.restore_all_windows)
	}
	item(title=title.desktop image=icon.desktop cmd=command.toggle_desktop)
	item(title=title.settings image=icon.settings(auto, image.color1) cmd='ms-settings:')
	item(title=str.res('C:\Windows\explorer.exe', -22001) sep=both image=icon.task_manager cmd='taskmgr.exe')
	item(title='Taskbar settings' sep=both image=inherit cmd='ms-settings:taskbar')
	item(vis=key.shift() title='Exit Explorer' cmd=command.restart_explorer)
}

Nilesoft shell is just failing to get the text for the entries. these settings just apply the text to the entries manually.

@CatPieLeaf CatPieLeaf changed the title Taskbar context menu is broken on Windows 11 Dev Taskbar context menu titles are broken on Windows 11 Dev Jul 25, 2024
@CatPieLeaf CatPieLeaf changed the title Taskbar context menu titles are broken on Windows 11 Dev Taskbar context menu titles are broken on Windows 11 Dev 26120.1252 Jul 25, 2024
@win98se
Copy link

win98se commented Jul 27, 2024

Can confirm on 26100.1297.

@CatsArmy
Copy link

Can confirm as well I suspect it could be that window changed the internal name of those names

@CHminggao
Copy link

same on 26100.1301

@RubicBG
Copy link
Collaborator

RubicBG commented Aug 5, 2024

can someone upload "C:\Windows\System32\shell32.dll" and "C:\Windows\explorer.exe"

@CatPieLeaf
Copy link
Author

CatPieLeaf commented Aug 5, 2024

can someone upload "C:\Windows\System32\shell32.dll" and "C:\Windows\explorer.exe"

From Windows dev build 26120.1330

shell32+explorer.zip

@RubicBG
Copy link
Collaborator

RubicBG commented Aug 6, 2024

and this one pls "C:\Windows\en-US\explorer.exe.mui"

@ararezaee
Copy link

ararezaee commented Aug 7, 2024

explorer files.zip

and this one pls "C:\Windows\en-US\explorer.exe.mui"

There you go both files from 26100.1301 which has the same issue

Screenshot 2024-08-07 220132

@RubicBG
Copy link
Collaborator

RubicBG commented Aug 7, 2024

all 71 ids responsible for Windows 10 and 11 taskbar context menu names have been removed.
even though the names don't come out, do the commands all execute?

item(title=str.res('C:\Windows\explorer.exe', -536))
item(title=str.res('C:\Windows\explorer.exe', -537))
item(title=str.res('C:\Windows\explorer.exe', -538))
item(title=str.res('C:\Windows\explorer.exe', -22001))

image
Only those names can be retrieved under those ids. Regardless of whether there is a name/text match these are not the names of the commands ("Show windows side by side" not the same as "Show windows s&ide by side")

@CatPieLeaf
Copy link
Author

CatPieLeaf commented Aug 7, 2024

These did work, i'll update the temporary workaround.

image

@CatsArmy
Copy link

CatsArmy commented Aug 8, 2024

Yeah they work just no name really weird choice form Microsoft with all the talk about backwards compatibility

@moudey
Copy link
Owner

moudey commented Aug 9, 2024

This issue has been fixed in Canary version 1.9.17 with an fallback title.

@CatPieLeaf
Copy link
Author

1.9.17 not pushed yet? latest canary still 1.9.16

@CatsArmy
Copy link

Nope I have . 17 don't know why it don work for you

@henk911
Copy link

henk911 commented Oct 6, 2024

same here

@CatPieLeaf CatPieLeaf changed the title Taskbar context menu titles are broken on Windows 11 Dev 26120.1252 [Fixed in 1.9.17] Taskbar context menu titles are broken on Windows 11 Dev 26120.1252 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants