fix some potentially confusing Process.start() comment

mostlygeek · mostlygeek · commit 60355bf74a63 · 2025-03-11T11:00:45.000-07:00
diff --git a/proxy/process.go b/proxy/process.go
@@ -116,7 +116,9 @@ func (p *Process) start() error {
 		return fmt.Errorf("can not start(), upstream proxy missing")
 	}
 
-	// wait for the other start() to complete
+	// multiple start() calls will wait for the one that is actually starting to
+	// complete before proceeding.
+	// ===========
 	curState := p.CurrentState()
 
 	if curState == StateReady {
@@ -132,6 +134,7 @@ func (p *Process) start() error {
 
 		return nil
 	}
+	// ===========
 
 	// There is the possibility of a hard to replicate race condition where
 	// curState *WAS* StateStopped but by the time we get to the p.stateMutex.Lock()

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,9 @@ func (p *Process) start() error {`
`116`	`116`	`return fmt.Errorf("can not start(), upstream proxy missing")`
`117`	`117`	`}`
`118`	`118`
`119`		`- // wait for the other start() to complete`
	`119`	`+ // multiple start() calls will wait for the one that is actually starting to`
	`120`	`+ // complete before proceeding.`
	`121`	`+ // ===========`
`120`	`122`	`curState := p.CurrentState()`
`121`	`123`
`122`	`124`	`if curState == StateReady {`
`@@ -132,6 +134,7 @@ func (p *Process) start() error {`
`132`	`134`
`133`	`135`	`return nil`
`134`	`136`	`}`
	`137`	`+ // ===========`
`135`	`138`
`136`	`139`	`// There is the possibility of a hard to replicate race condition where`
`137`	`140`	`// curState WAS StateStopped but by the time we get to the p.stateMutex.Lock()`