feat(api): encrypt/decrypt api #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 60.39% // Head: 60.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 133 133
Lines 8398 8398
=======================================
Hits 5072 5072
Misses 2738 2738
Partials 588 588 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: seeflood <[email protected]>
|
@kevinten10 Hi, I modified the proto according to our discussion. |
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
wenxuwan
approved these changes
Oct 12, 2022
zhenjunMa
approved these changes
Oct 12, 2022
kevinten10
reviewed
Oct 14, 2022
| message DecryptResponse { | ||
|
|
||
| // Raw plaintext. | ||
| bytes plain_text = 1; |
There was a problem hiding this comment.
我在 #794 中提到了一个例子，去掉status之后似乎没办法表示？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: seeflood [email protected]
What this PR does:
encrypt/decrypt api
Which issue(s) this PR fixes:
Fixes #794
Special notes for your reviewer:
Does this PR introduce a user-facing change?: