feat: component ref #761
Merged
feat: component ref #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # components/ref/config.go # pkg/runtime/ref/injector.go # pkg/runtime/ref/injector_test.go
seeflood
reviewed
Aug 20, 2022
Codecov ReportBase: 60.56% // Head: 60.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 60.56% 60.39% -0.17%
==========================================
Files 133 133
Lines 8340 8398 +58
==========================================
+ Hits 5051 5072 +21
- Misses 2712 2738 +26
- Partials 577 588 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ZLBer
force-pushed
the
secret_ref_key
branch
from
cccb119
to
33d9aa8
Compare
seeflood
requested changes
Sep 27, 2022
seeflood
reviewed
Sep 27, 2022
seeflood
reviewed
Sep 27, 2022
seeflood
requested changes
Sep 29, 2022
seeflood
requested changes
Sep 29, 2022
seeflood
requested changes
Sep 29, 2022
|
@ZLBer By the way, could u add documentation for this feature? Maybe in some other PR |
|
@seeflood sure, i will add a doc in another pr. |
zhenjunMa
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
add component ref
Which issue(s) this PR fixes:
Fixes #756
Special notes for your reviewer:
Does this PR introduce a user-facing change?: