Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some cleanup work for oss api #746

Merged
merged 9 commits into from
Jul 30, 2022
Merged

Conversation

seeflood
Copy link
Member

Signed-off-by: seeflood [email protected]

What this PR does:

  • change the naming style from awsOSS to aws.s3
    image

  • add comments for components/oss/oss.go
    Maybe one line comment which refers to some other doc is enough
    image

  • modify makefile script to compile .proto files with specific protoc version. See feat: implement oss interface #556 (comment)

  • generate api reference doc

Which issue(s) this PR fixes:

Fixes part of the subtasks in #723

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


zhenjunMa
zhenjunMa previously approved these changes Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #746 (aabb722) into main (69d04ec) will not change coverage.
The diff coverage is 15.00%.

@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files         133      133           
  Lines        8318     8318           
=======================================
  Hits         5041     5041           
  Misses       2700     2700           
  Partials      577      577           
Impacted Files Coverage Δ
components/file/minio/oss.go 45.00% <9.09%> (ø)
components/file/aws/file.go 25.18% <22.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5050f...aabb722. Read the comment docs.

Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@seeflood seeflood merged commit 11db6f2 into mosn:main Jul 30, 2022
@seeflood seeflood deleted the clean_oss_up branch July 30, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants