-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: some cleanup work for oss api #746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
zhenjunMa
previously approved these changes
Jul 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #746 +/- ##
=======================================
Coverage 60.60% 60.60%
=======================================
Files 133 133
Lines 8318 8318
=======================================
Hits 5041 5041
Misses 2700 2700
Partials 577 577
Continue to review full report at Codecov.
|
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
wenxuwan
approved these changes
Jul 30, 2022
zhenjunMa
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: seeflood [email protected]
What this PR does:
change the naming style from
awsOSS
toaws.s3
add comments for
components/oss/oss.go
Maybe one line comment which refers to some other doc is enough
modify makefile script to compile
.proto
files with specific protoc version. See feat: implement oss interface #556 (comment)generate api reference doc
Which issue(s) this PR fixes:
Fixes part of the subtasks in #723
Special notes for your reviewer:
Does this PR introduce a user-facing change?: