Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add email.proto #729

Merged
merged 14 commits into from
Aug 19, 2022
Merged

feat(api): add email.proto #729

merged 14 commits into from
Aug 19, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Jul 21, 2022

Signed-off-by: seeflood [email protected]

What this PR does:
add email.proto

Which issue(s) this PR fixes:

Fixes #717

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Base: 60.56% // Head: 60.56% // No change to project coverage 👍

Coverage data is based on head (7deb8c3) compared to base (b150b3f).
Patch has no changes to coverable lines.

❗ Current head 7deb8c3 differs from pull request most recent head 4503b6c. Consider uploading reports for the commit 4503b6c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #729   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8323     8323           
=======================================
  Hits         5041     5041           
  Misses       2705     2705           
  Partials      577      577           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seeflood seeflood mentioned this pull request Jul 26, 2022
zhenjunMa
zhenjunMa previously approved these changes Aug 12, 2022
@seeflood
Copy link
Member Author

I will generate code and documentation after the proto is merged.

Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit 5d6b463 into mosn:main Aug 19, 2022
@seeflood seeflood deleted the email_api branch August 19, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Email notify API [SaaS API]
4 participants