Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hello component #695

Merged
merged 37 commits into from
Jul 4, 2022
Merged

Conversation

MichaelDeSteven
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@MichaelDeSteven MichaelDeSteven changed the title typo: hello component fix: hello component Jul 3, 2022
@mosn-community-bot mosn-community-bot bot added the bug Something isn't working label Jul 3, 2022
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #695 (8943192) into main (98c60b2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   60.95%   60.95%           
=======================================
  Files         120      120           
  Lines        6388     6388           
=======================================
  Hits         3894     3894           
  Misses       2121     2121           
  Partials      373      373           
Impacted Files Coverage Δ
components/hello/registry.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c60b2...8943192. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@seeflood seeflood merged commit e3d78d6 into mosn:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants