Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make error message in "🌈 Go Style Check" more readable #678

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Jun 28, 2022

Signed-off-by: seeflood [email protected]

What this PR does:
I spent some time telling @dzdx how to fix the CI error in #676 .
It's not cool.
So I think we should make error message in "🌈 Go Style Check" more readable
image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #678 (9fec569) into main (d1f66c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files         120      120           
  Lines        6384     6384           
=======================================
  Hits         3890     3890           
  Misses       2121     2121           
  Partials      373      373           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4f49e...9fec569. Read the comment docs.

@seeflood seeflood changed the title ci: make error message more readable ci: make error message in "🌈 Go Style Check" more readable Jun 28, 2022
@seeflood seeflood requested a review from Xunzhuo June 28, 2022 06:40
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting:) LGTM

@seeflood seeflood closed this Jun 28, 2022
@seeflood seeflood reopened this Jun 28, 2022
@Xunzhuo
Copy link
Member

Xunzhuo commented Jun 30, 2022

I am going to merge this, ci failed no related to this PR.

@Xunzhuo Xunzhuo merged commit 97aedf9 into mosn:main Jun 30, 2022
@seeflood seeflood deleted the improve_error_messages branch June 30, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants