-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: goimports failed in make all #583
Conversation
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
=======================================
Coverage 60.70% 60.70%
=======================================
Files 120 120
Lines 6382 6382
=======================================
Hits 3874 3874
Misses 2139 2139
Partials 369 369 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rayowang ,but actually this is not what I expect.
In the new commands, we will clone three repos which are not in small size too and it contains some tools we do not need, and we need to link them(Isn`t it too complex?).
Why do not we just use go get goimports to just install goimports? We will also face the network issue again even if we choose to clone it from github. Dealing with the network issue should not be a task from the team in my view.
@Xunzhuo Because golang.org is 100% banned, but github.com is "sometimes" banned. So chinese users can "sometimes" download goimports from github succesfully, but can never download from golang.org How about we use docker to run goimports? It can solve the network issue (by using a dockerhub mirror site) and preventing errors caused by different versions of goimports Or.....we add some new commands, e.g. |
…into fix_make_all_goimports
@Xunzhuo I just saw the message, I think what you said makes sense, but as seeflood @seeflood said, it is impossible to access golang.org in China. In fact, some VPN tools may not work. The person who opened the issue before has been doing it for a long time. Of course, it is better to build in docker, but this will lose the convenience of local build, so this way is a temporary compromise. |
@Xunzhuo Any idea on this PR? |
I am Okay with this, thanks @rayowang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
What this PR does:
I also encountered a similar problem before. After I cloned the registry from github, it was ok to map it to the registry corresponding to golang.org. But a better solution might be to use a good VPN.
Which issue(s) this PR fixes:
#569