Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:aws oss #523

Merged
merged 8 commits into from
May 5, 2022
Merged

fix:aws oss #523

merged 8 commits into from
May 5, 2022

Conversation

akkw
Copy link
Contributor

@akkw akkw commented May 2, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #503

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #523 (7770a63) into main (d0f7841) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 7770a63 differs from pull request most recent head bce3a5c. Consider uploading reports for the commit bce3a5c to get more accurate results

@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   60.62%   60.68%   +0.06%     
==========================================
  Files         120      120              
  Lines        6384     6384              
==========================================
+ Hits         3870     3874       +4     
+ Misses       2144     2140       -4     
  Partials      370      370              
Impacted Files Coverage Δ
components/file/s3/aws/oss.go 29.53% <0.00%> (+2.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf2ce78...bce3a5c. Read the comment docs.

components/file/s3/aws/oss_test.go Show resolved Hide resolved
components/file/s3/aws/oss_test.go Outdated Show resolved Hide resolved
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for your contribution!

@seeflood seeflood requested review from a team and removed request for a team May 2, 2022 10:36
components/file/s3/aws/oss_test.go Show resolved Hide resolved
components/file/s3/aws/oss_test.go Outdated Show resolved Hide resolved
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit 1b9e7fe into mosn:main May 5, 2022
@seeflood
Copy link
Member

seeflood commented May 5, 2022

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws file will panic
3 participants